⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Can't config listeners nodeSelector and tolerations whitout rewriting the whole spec block #4350

@ianbabysre

Description

@ianbabysre

Checks

Controller Version

0.13.0

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

Define listenerTemplate spec with only nodeSelector for ex and it don't be templated

Describe the bug

When trying to set nodeSelector and/or tolerations, the helm templating breaks with error

listenerTemplate:
  spec:
    nodeSelector:
      dedicated: "compute"
    tolerations:
      - key: "kubernetes.azure.com/scalesetpriority"
        operator: "Equal"
        value: "spot"
        effect: "NoSchedule"

one or more objects failed to apply, reason: AutoscalingRunnerSet.actions.github.com is invalid: spec.listenerTemplate.spec.containers: Required value

In this issue, @nikola-jokic mentioned that we could configure it like this but it's not working because of the templating

Describe the expected behavior

Defining nodeSelector, toleration or any other standard k8s fields should be allowed and (a bit better) documented ?

In the controller chart, it's very easy to do so

Additional Context

Example with a subchart of a failing configuration
gha-runner-scale-set:
      listenerTemplate:
        spec:
          nodeSelector:
            dedicated: "compute"
          tolerations:
            - key: "kubernetes.azure.com/scalesetpriority"
              operator: "Equal"
              value: "spot"
              effect: "NoSchedule"

Controller Logs

N/A since because it's on templating level

Runner Pod Logs

N/A since because it's on templating level

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggha-runner-scale-setRelated to the gha-runner-scale-set modeneeds triageRequires review from the maintainers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions