⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Remove unused constructor parameter from NapiJSITaskRunner #78

@JunielKatarn

Description

@JunielKatarn

NapiJSITaskRunner(napi_env env, napi_ext_schedule_task_callback scheduler) : env_{env}, scheduler_{scheduler} {}

Can we remove it since we cannot really pass a valid value?

Also, address other minor suggestions in the same PR.


Refers to: src/napi/js_native_ext_api_v8.cpp:216 in 30f63cb. [](commit_id = 30f63cb, deletion_comment = False)

Originally posted by @vmoroz in #77 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions