diff --git a/src/vs/workbench/contrib/chat/common/model/chatProgressTypes/chatElicitationRequestPart.ts b/src/vs/workbench/contrib/chat/common/model/chatProgressTypes/chatElicitationRequestPart.ts index aefae323291cc..8e629c5e47e1a 100644 --- a/src/vs/workbench/contrib/chat/common/model/chatProgressTypes/chatElicitationRequestPart.ts +++ b/src/vs/workbench/contrib/chat/common/model/chatProgressTypes/chatElicitationRequestPart.ts @@ -5,12 +5,11 @@ import { IAction } from '../../../../../../base/common/actions.js'; import { IMarkdownString } from '../../../../../../base/common/htmlContent.js'; -import { Disposable } from '../../../../../../base/common/lifecycle.js'; import { IObservable, observableValue } from '../../../../../../base/common/observable.js'; import { ElicitationState, IChatElicitationRequest, IChatElicitationRequestSerialized } from '../../chatService/chatService.js'; import { ToolDataSource } from '../../tools/languageModelToolsService.js'; -export class ChatElicitationRequestPart extends Disposable implements IChatElicitationRequest { +export class ChatElicitationRequestPart implements IChatElicitationRequest { public readonly kind = 'elicitation2'; public state = observableValue('state', ElicitationState.Pending); public acceptedResult?: Record; @@ -32,8 +31,6 @@ export class ChatElicitationRequestPart extends Disposable implements IChatElici public readonly moreActions?: IAction[], public readonly onHide?: () => void, ) { - super(); - if (reject) { this.reject = async () => { const state = await reject!(); @@ -54,7 +51,7 @@ export class ChatElicitationRequestPart extends Disposable implements IChatElici } this._isHiddenValue.set(true, undefined, undefined); this.onHide?.(); - this.dispose(); + this.state.set(ElicitationState.Rejected, undefined); } public toJSON() { diff --git a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts index db346101787e2..eb1d8c9a3b848 100644 --- a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts +++ b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts @@ -711,7 +711,7 @@ export class OutputMonitor extends Disposable implements IOutputMonitor { } let part!: ChatElicitationRequestPart; const promise = new Promise(resolve => { - const thePart = part = this._register(new ChatElicitationRequestPart( + const thePart = part = new ChatElicitationRequestPart( title, detail, subtitle, @@ -744,7 +744,7 @@ export class OutputMonitor extends Disposable implements IOutputMonitor { undefined, // source moreActions, () => this._outputMonitorTelemetryCounters.inputToolManualShownCount++ - )); + ); chatModel.acceptResponseProgress(request, thePart); this._promptPart = thePart;