feat: Add --dark flag to iv for Dark Mode#5019
Open
sh4shv4t wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
feat: Add --dark flag to iv for Dark Mode#5019sh4shv4t wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
sh4shv4t wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
|
|
Signed-off-by: sh4shv4t <shashvat.kk@gmail.com> Signed-off-by: sh4shv4t <shashvat.k.singh.16@gmail.com>
21381a5 to
c73846c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4710
Description
This PR implements the core Dark Mode logic for the
ivviewer.Current Implementation:
--darkcommand-line argument.QPalette.Note on Preferences:
I noticed the request in the issue to add this to the Preferences Menu for persistence. I wanted to submit the CLI implementation first to verify that the
Fusionstyle and color palette meet the project's visual standards.Once this styling is approved, I am happy to add the Preferences toggle and persistence logic in a follow-up commit to this PR.
Tests
iv.exe --dark test_image.jpg: Verified the UI loaded in dark mode.iv.exe test_image.jpg: Verified the UI loaded in standard mode.Checklist:
--helpoutput is automatically updated).