Closed
Conversation
drvinceknight
requested changes
Apr 10, 2020
Member
drvinceknight
left a comment
drvinceknight
left a comment
There was a problem hiding this comment.
Looks good, could you add the specific command to run black to this page of the docs please: https://axelrod.readthedocs.io/en/stable/tutorials/contributing/guidelines.html
(The format of bullet point 3 is a bit weird if you could fix that while you're there.)
Member
|
I didn't think there would be so many changes to so many files, do you mind holding off until after I finish #1288 ? I'm assuming that you would just have to run black again and that wouldn't create much extra effort. |
Member
Author
|
@marcharper That's fine with me. |
Member
I was surprised when you suggested it would be fine :) 👍 |
| all code and the `isort utility <https://github.com/timothycrosley/isort>`_ to | ||
| sort import statements. You can run black on all code with:: | ||
|
|
||
| $ python -m black -l 80 . |
Merged
Member
|
Closing in favor of #1368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1312
First commit runs black on all files. Second commit adds a check to config.yml.
I didn't make any changes to the contribution docs, because they already say that you should run black on all files.