-
Notifications
You must be signed in to change notification settings - Fork 662
MAINT Migration from mypy to ty #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MAINT Migration from mypy to ty #1319
Conversation
- no official pre commit hook support for ty: astral-sh/ty#269
|
Note 1: There is no pre commit hook for
ref: |
|
Note 2: await outside func/async function We are getting errors saying
It is something under discussion there:
And then we got reply saying:
I think it will take quite a while to get this feature. ref: |
- `ty` doesn't have any allow empty body config afaik
|
Here is existing And here is what I am migrating into: And here is my mapping, or the reason:
Open for discussion, if I am missing something. Just wanted to clarify. ref: |
Yes, I wrote that, but the purpose of this item would be to replace mypy with ty including in pre-commit. |
Every py file under /doc can have await outside functions so those should be ignored there (only there!) |
|
@romanlutz that is something I am working on. I will share related links soon. I am also trying to write rules for |
|
@maifeeulasad let me know if you need any help 🙂 |
|
Implemented a new In the background I was looking for pre commit hook, which does the exact same thing as we do here. This is my update so far! Is there any deadline? @romanlutz ref: |
|
Incredible! That is arguably a service to the entire community using ty! There's no particular deadline but we are obviously eager to stop wasting time with mypy 🙂 Thanks for the update. I can see that you're very much on top of it. Please don't feel rushed. |
Description
closes #1313
Tests and Documentation