{Compute} migrate vm disk attach/detach to aaz #32583
Open
+24,201
−30,516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiii99
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
❌AzureCLI-FullTest
|
|
Hi @huiii99, |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the az vm disk attach and az vm disk detach commands from hand-written SDK code to the AAZ (Azure CLI Auto-generated) framework. The migration introduces the use of AAZ operations (AttachDetachDataDisk, VMShow, VMUpdate) while maintaining backward compatibility for different disk attachment scenarios.
Key changes include:
- Refactored
attach_managed_data_diskto use AAZ operations for existing disk attachments and VMUpdate for new/copy/restore operations - Refactored
detach_managed_data_diskto use AAZ operations with improved error handling - Added a new
safe_getutility function for safely accessing nested dictionary keys
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Refactored disk attach/detach functions to use AAZ operations; added no_wait parameter support; reorganized logic into separate code paths for different attachment types |
| src/azure-cli/azure/cli/command_modules/vm/_vm_utils.py | Added new safe_get utility function for safe nested dictionary access with fallback defaults |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
huiii99
force-pushed
the
vm-disk-attach-detach-aaz-migration
branch
from
e20c674 to
a294602
Compare
fix: resolve review issues fix: check cli style dev dev
huiii99
force-pushed
the
vm-disk-attach-detach-aaz-migration
branch
from
8beb7bb to
d566b6a
Compare
…com/huiii99/azure-cli into vm-disk-attach-detach-aaz-migration
huiii99
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm disk attachaz vm disk detachDescription
Migrate
az vm disk attachandaz vm disk detachcommands from hand written sdk to aaz.Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.