app: Add ParameterMissing exception handling #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awilfox
requested review from
anarchivist,
davezuckerman,
jason-raitz,
steve-sullivan and
yzhoubk
Member
Author
|
I will fix the test failures, forgot to rebuild the container locally before running |
jason-raitz
approved these changes
Feb 11, 2026
Contributor
jason-raitz
left a comment
jason-raitz
left a comment
There was a problem hiding this comment.
lgtm once tests pass. If the other exceptions have tests, then this one should as well.
awilfox
force-pushed
the
awilfox/param-bad-request
branch
from
3f665ff to
0085266
Compare
This way, if a parameter is missing in a request, it is logged as a 400 Bad Request instead of a 500 Internal Server Error.
awilfox
force-pushed
the
awilfox/param-bad-request
branch
from
0085266 to
27c9926
Compare
Member
Author
|
v3: Rebased. The other exceptions don't seem to have tests, so I think this is good after CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, if a parameter is missing in a request, it is logged as a 400 Bad Request instead of a 500 Internal Server Error.
Inspired by this morning's discussion over the
/feesendpoint. TBD: should there be tests added for this?