AP-513 & AP-186 improve log tracing #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When active_jobs are enqueued, this will add current_attributes for jobid, request_id, and ip_address.
- removes remote_ip from log message
- only add a request_id to the job if there is a request_id specs tend not to stub out request_id
- tests request_id manipulation around queues - tests attaching activejob_id and request_id to logs
jason-raitz
requested review from
anarchivist,
awilfox,
davezuckerman,
steve-sullivan and
yzhoubk
Contributor
Author
|
I'll rebase if needed before merging. |
anarchivist
approved these changes
Feb 12, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
a few questions, but mostly looks good!
davezuckerman
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a system for propagating the current HTTP request ID through background jobs, enabling improved traceability and logging. The main changes include capturing the request ID in controllers, passing it to jobs, and logging it with job metadata. Comprehensive tests are also added to verify this behavior.
Request ID propagation and logging:
Currentmodel usingActiveSupport::CurrentAttributesto store therequest_idfor the current thread/request.ApplicationControllerto setCurrent.request_idbefore each request, ensuring the request ID is available throughout the request lifecycle. [1] [2]ApplicationJobto append therequest_idto job arguments before enqueueing, extract and set it during job execution, and log it alongside the job ID for improved traceability.Testing enhancements:
application_job_spec.rb) to verify that jobs correctly handle the presence or absence ofrequest_id, including argument manipulation and logging behavior.Closes AP-513 & AP-186
Co-authored-by @steve-sullivan