⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

Copy link

Copilot AI commented Feb 11, 2026

Two spec files used multi-line expect do...end blocks while the codebase standard (established in AffiliateBorrowRequestFormSpec) uses inline expect { } syntax.

Changes

  • spec/models/doemoff_patron_email_form_spec.rb: Converted expect do...end to expect { }
  • spec/models/efees_invoice_spec.rb: Converted expect do...end to expect { }

Example

# Before
expect do
  @form.submit!
end.to have_enqueued_job(ActionMailer::MailDeliveryJob).with(...)

# After
expect { @form.submit! }.to have_enqueued_job(ActionMailer::MailDeliveryJob).with(...)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

David Zuckerman and others added 2 commits February 11, 2026 13:07
added struct file for affiliate borrow request

moved struct into model for borrow_request

removed borrow_request.rb struct file

Changing doemoff_patron_email_form to use struct similar to affiliate_borrower

Changing stack pass for to use deliver_later

Changed deliver_now to deliver_later for more forms

Update request_mailer to work with update to efees which uses deliver_later now

removed ActiveJob::Base.queue_adapter = :test from affiliate_borrow_request_form, already a default
Base automatically changed from AP-512-deliver-later to main February 11, 2026 21:17
Copy link
Author

Copilot AI commented Feb 11, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Copilot AI changed the title [WIP] Update forms to use deliver_later instead of deliver_now Standardize test block syntax for consistency with existing patterns Feb 11, 2026
Copilot AI requested a review from davezuckerman February 11, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants