Working ObserverAI and watch_replay.py#138
Working ObserverAI and watch_replay.py#138SoupCatcher wants to merge 1 commit intoBurnySc2:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #138 +/- ##
===========================================
- Coverage 79.75% 78.85% -0.91%
===========================================
Files 93 94 +1
Lines 12291 12434 +143
===========================================
+ Hits 9803 9805 +2
- Misses 2488 2629 +141
Continue to review full report at Codecov.
|
|
I'd like to add a test that runs the But for that I need a replay file. And that replay file might be incompatible with different python-sc2 versions, so I'd have to generate it in the CI. Additionally the replays may only be watched if the map file is available, but the docker image should have those. This is just me speaking my mind and what needs to be done before merging this PR. |
This works for me: