Set default python version 3.9 and fix strenum problem#135
Set default python version 3.9 and fix strenum problem#135
Conversation
|
jacomago
requested review from
anderslindho,
ralphlange,
shroffk,
simon-ess and
tynanford
|
I tried to get this check in the pre-commit, but adding all ruff lints wasn't enough, I had to add type checking... Which made the PR huge. So I'll stick with just this change for now. |
| hooks: | ||
| # Run the linter. | ||
| - id: ruff | ||
| args: [ --fix ] |
There was a problem hiding this comment.
Don't think this is needed anymore, and the hook has been renamed (ruff-check IIRC)
| name="recceiver" | ||
| name = "recceiver" | ||
| version = "1.5" | ||
| description = "resync server" |
| [project.urls] | ||
| Repository="https://github.com/mdavidsaver/recsync" | ||
| optional-dependencies.test = [ "pytest", "testcontainers>=4" ] | ||
| urls.Repository = "https://github.com/mdavidsaver/recsync" |
There was a problem hiding this comment.
I think this is wrong?
There was a problem hiding this comment.
We can blame that on me!
See https://github.com/ChannelFinder/recsync/blame/master/server/pyproject.toml and previously (10 yrs ago!) https://github.com/ChannelFinder/recsync/blame/88665ce9943d9883f00326fda58c027ad9a050df/server/setup.py
|
|
||
| [tool.ruff] | ||
| line-length = 120 | ||
| target-version = "py39" |
There was a problem hiding this comment.
This doesn't mesh well with your attempt to externalise python version into a variable
|
|
||
| [tool.pytest.ini_options] | ||
| log_cli = true | ||
| log_cli_level = "DEBUG" |
There was a problem hiding this comment.
Do we really need this as default?
3 participants
No description provided.