London | 25-SDC-July | Andrei Filippov | Sprint 1 | Analyse and Refactor Functions #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Droid-An
added
the
Needs Review
cjyuan
reviewed
Jan 22, 2026
|
|
||
| # it's better to use to pointers method here | ||
| # first: sort the list O(n) | ||
| numbers = sorted(numbers) |
There was a problem hiding this comment.
Comparison-based sorting algorithm is at best O(nlogn).
Note: Without sorting, an O(n) approach involving map/dict is still possible.
Author
There was a problem hiding this comment.
Hi, thank you for the review. I didn’t know that the sorted() function has O(n log n) time complexity. After googling it, I learned that this is because sorted() uses the Timsort algorithm.
I followed your suggestion and found a better algorithm to find sum in O(n) time by using set.
cjyuan
added
Reviewed
Droid-An
added
Needs Review
|
Changes look good. |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Refactored code to reduce time complexity
Questions
no questions