London | 25-SDC-July | Andrei Filippov | Sprint 2 | Improve code with precomputing #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Droid-An
added
the
Needs Review
OracPrime
added
the
Review in progress
OracPrime
reviewed
Jan 26, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
Common Prefix is good, counting letters needs a little attention
| return letter == letter.upper() | ||
| only_upper = 0 | ||
| only_uniq = set(s) | ||
| only_uniq_sorted = sorted(only_uniq) |
Author
There was a problem hiding this comment.
Probably it's unnecessary here
| uppercase = [ch for ch in only_uniq_sorted if ch.isupper()] | ||
| lowercase = [ch for ch in only_uniq_sorted if ch.islower()] | ||
| for i in uppercase: | ||
| if i.lower() not in lowercase: |
There was a problem hiding this comment.
Because lowercase is a list, this is potentially slow. What else could you use?
Author
There was a problem hiding this comment.
I can use sets here, because look up in a set is O(1) on average, while checking in a list is O(n).
OracPrime
added
Reviewed
…unnecessary sorting
Droid-An
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Improved code with precomputing
Questions
no questions