⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@rondlh
Copy link
Contributor

@rondlh rondlh commented Jan 12, 2026

Update snap grid support in Manipulation.java

Update snap grid support in Manipulation.java
@madhephaestus madhephaestus merged commit b606d62 into CommonWealthRobotics:development Jan 12, 2026
1 check passed
@madhephaestus
Copy link
Member

THis is a major improvement! i do notice the object sort of runs away from the mounse instead of lagging it. When its an an angle its a bit confusing, but TBH it is better than it was by a lot!

@rondlh
Copy link
Contributor Author

rondlh commented Jan 13, 2026

THis is a major improvement! i do notice the object sort of runs away from the mounse instead of lagging it. When its an an angle its a bit confusing, but TBH it is better than it was by a lot!

Thanks for the feedback. There is a compensation build in that tries to compensate for the initial offset that is introduced to implement the snap grip, but because the handle position doesn't follow the mouse very accurately this only works locally to the starting point. Either way, for small snap grids this already works quite well, and for large snap grids you will always feel a bit of a fight.

I found the top arrow handle is implemented in completely different way than the top and corner handles, I expected them to be in the same class.

The next step is to make the handles follow the mouse more accurately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants