⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@MeMyselfMirai
Copy link

You're welcome Joe.

A few days ago, this happened:
image

This change inserts spaces after any @ signs in major project submissions. This should prevent such a ping from happening again.

@shaeespring
Copy link
Contributor

@MeMyselfMirai If you fix the merge conflict (It's a formatting thing), this looks very good. I'd like to see this in dev

Copy link
Contributor

@Qelxiros Qelxiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@Qelxiros
Copy link
Contributor

oh this is super old
@MeMyselfMirai if you don't want to update this you should close it

@shaeespring
Copy link
Contributor

oh this is super old @MeMyselfMirai if you don't want to update this you should close it

Disagree. If @MeMyselfMirai doesn't want to do it, I will, I just want to give the original author a chance first

Copy link
Contributor

@BigSpaceships BigSpaceships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants