MOBILE-16529-Add-examples-for-bottom-sheets-menus-and-dialogs#69
Merged
kavin-csquare merged 4 commits intomasterfrom Jul 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds example implementations for bottom sheets, menus, and dialogs in the sample app, including UI resources, layouts, fragments, and masking integrations.
- Introduces new strings and menu items for masking/unmasking content
- Adds layouts and fragments for bottom sheet, date/time pickers, and custom alerts
- Updates
SimpleActivitywith buttons, dialog handlers, and ContentSquare masking calls
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Added AI descriptions, menu/dialog labels |
| app/src/main/res/menu/simple_menu.xml | New menu with masked/unmasked items |
| app/src/main/res/layout/fragment_bottom_sheet_dialog.xml | Layout for bottom sheet |
| app/src/main/res/layout/dialog_custom_alert.xml | Layout for custom alert dialog |
| app/src/main/res/layout/activity_simple.xml | Converted to ConstraintLayout and added buttons |
| app/src/main/res/drawable/dialog_background.xml | Shape drawable for custom dialog background |
| app/src/main/java/com/example/androidsampleapp/fragment/TimePickerFragment.kt | Time picker fragment with masking |
| app/src/main/java/com/example/androidsampleapp/fragment/DatePickerFragment.kt | Date picker fragment with masking (interface unused) |
| app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt | Custom alert dialog with masking setup |
| app/src/main/java/com/example/androidsampleapp/fragment/BottomSheetFragment.kt | Bottom sheet fragment implementation |
| app/src/main/java/com/example/androidsampleapp/SimpleActivity.kt | Added menu inflation, masking, button callbacks |
Comments suppressed due to low confidence (2)
app/src/main/res/values/strings.xml:98
- Resource names should use snake_case per Android conventions; consider renaming
contentSquaretocontent_square.
<string name="contentSquare">CSquare</string>
app/src/main/res/layout/activity_simple.xml:12
- [nitpick] XML view IDs should follow snake_case naming for consistency (e.g.,
btn_bottom_sheetsinstead ofbtnBottomSheets).
android:id="@+id/btnBottomSheets"
app/src/main/java/com/example/androidsampleapp/fragment/DatePickerFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/BottomSheetFragment.kt
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/DatePickerFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/TimePickerFragment.kt
Outdated
Show resolved
Hide resolved
stefan222
reviewed
Jul 1, 2025
stefan222
approved these changes
Jul 3, 2025
Contributor
stefan222
left a comment
There was a problem hiding this comment.
Thank you, @kavin-csquare !
ricardo-markiewicz-cs
approved these changes
Jul 3, 2025
Contributor
ricardo-markiewicz-cs
left a comment
There was a problem hiding this comment.
LGTM, thanks @kavin-csquare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.