Remove unneeded/breaking code, update camera example#3
Open
javl wants to merge 1 commit intoDanielArnett:masterfrom
Open
Remove unneeded/breaking code, update camera example#3javl wants to merge 1 commit intoDanielArnett:masterfrom
javl wants to merge 1 commit intoDanielArnett:masterfrom
Conversation
Removes System.Drawing dependency as this is not being used but does break the code from working on non-Windows systems. Updates the camera example to a new, functional source.
dustinkerstein
left a comment
dustinkerstein
left a comment
There was a problem hiding this comment.
I can confirm these changes work for me on OSX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this example, it was just what I needed to use my IP camera as a texture.
I did have some trouble finding a cross-platform alternative to
System.Drawing.dll, but found out this include is not even used by the script. So this pull request removes that line, together with the unusedpublic Bitmap bitmap { get; set; }. This way, the script works both on Windows and Linux (and probably MacOS as well).I also updated the webcam example link to a new, functional source. I did not update the other files generated by Unity, as those will get updated by the user's latest Unity version anyway.