-
Notifications
You must be signed in to change notification settings - Fork 324
Allow running wallclock profiler even without tracer #10298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1094980
Total [baseline] (10.93 s) : 0, 10929599
Agent [candidate] (1.087 s) : 0, 1086905
Total [candidate] (10.864 s) : 0, 10863788
section appsec
Agent [baseline] (1.274 s) : 0, 1273684
Total [baseline] (11.045 s) : 0, 11044747
Agent [candidate] (1.268 s) : 0, 1268291
Total [candidate] (11.106 s) : 0, 11106314
section iast
Agent [baseline] (1.226 s) : 0, 1226475
Total [baseline] (11.169 s) : 0, 11169024
Agent [candidate] (1.225 s) : 0, 1224553
Total [candidate] (11.063 s) : 0, 11063008
section profiling
Agent [baseline] (1.207 s) : 0, 1207294
Total [baseline] (10.975 s) : 0, 10975330
Agent [candidate] (1.204 s) : 0, 1203785
Total [candidate] (10.894 s) : 0, 10894318
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (656.981 ms) : 0, 656981
BytebuddyAgent [candidate] (653.191 ms) : 0, 653191
GlobalTracer [baseline] (285.838 ms) : 0, 285838
GlobalTracer [candidate] (283.341 ms) : 0, 283341
AppSec [baseline] (33.158 ms) : 0, 33158
AppSec [candidate] (32.73 ms) : 0, 32730
Debugger [baseline] (68.606 ms) : 0, 68606
Debugger [candidate] (67.503 ms) : 0, 67503
Remote Config [baseline] (647.462 µs) : 0, 647
Remote Config [candidate] (659.65 µs) : 0, 660
Telemetry [baseline] (9.055 ms) : 0, 9055
Telemetry [candidate] (8.982 ms) : 0, 8982
Flare Poller [baseline] (3.871 ms) : 0, 3871
Flare Poller [candidate] (3.769 ms) : 0, 3769
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (696.458 ms) : 0, 696458
BytebuddyAgent [candidate] (692.239 ms) : 0, 692239
GlobalTracer [baseline] (260.77 ms) : 0, 260770
GlobalTracer [candidate] (259.764 ms) : 0, 259764
AppSec [baseline] (174.209 ms) : 0, 174209
AppSec [candidate] (172.774 ms) : 0, 172774
Debugger [baseline] (66.943 ms) : 0, 66943
Debugger [candidate] (68.454 ms) : 0, 68454
Remote Config [baseline] (754.298 µs) : 0, 754
Remote Config [candidate] (856.807 µs) : 0, 857
Telemetry [baseline] (9.177 ms) : 0, 9177
Telemetry [candidate] (9.258 ms) : 0, 9258
Flare Poller [baseline] (3.813 ms) : 0, 3813
Flare Poller [candidate] (3.796 ms) : 0, 3796
IAST [baseline] (24.82 ms) : 0, 24820
IAST [candidate] (24.498 ms) : 0, 24498
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (792.11 ms) : 0, 792110
BytebuddyAgent [candidate] (791.213 ms) : 0, 791213
GlobalTracer [baseline] (257.509 ms) : 0, 257509
GlobalTracer [candidate] (257.075 ms) : 0, 257075
AppSec [baseline] (34.523 ms) : 0, 34523
AppSec [candidate] (33.495 ms) : 0, 33495
Debugger [baseline] (65.954 ms) : 0, 65954
Debugger [candidate] (66.517 ms) : 0, 66517
Remote Config [baseline] (614.882 µs) : 0, 615
Remote Config [candidate] (587.302 µs) : 0, 587
Telemetry [baseline] (8.49 ms) : 0, 8490
Telemetry [candidate] (8.461 ms) : 0, 8461
Flare Poller [baseline] (3.594 ms) : 0, 3594
Flare Poller [candidate] (3.568 ms) : 0, 3568
IAST [baseline] (27.046 ms) : 0, 27046
IAST [candidate] (27.074 ms) : 0, 27074
section profiling
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (704.755 ms) : 0, 704755
BytebuddyAgent [candidate] (702.414 ms) : 0, 702414
GlobalTracer [baseline] (221.131 ms) : 0, 221131
GlobalTracer [candidate] (221.099 ms) : 0, 221099
AppSec [baseline] (32.232 ms) : 0, 32232
AppSec [candidate] (32.116 ms) : 0, 32116
Debugger [baseline] (67.882 ms) : 0, 67882
Debugger [candidate] (67.822 ms) : 0, 67822
Remote Config [baseline] (623.973 µs) : 0, 624
Remote Config [candidate] (628.393 µs) : 0, 628
Telemetry [baseline] (8.841 ms) : 0, 8841
Telemetry [candidate] (8.798 ms) : 0, 8798
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.719 ms) : 0, 3719
ProfilingAgent [baseline] (96.745 ms) : 0, 96745
ProfilingAgent [candidate] (96.148 ms) : 0, 96148
Profiling [baseline] (97.328 ms) : 0, 97328
Profiling [candidate] (96.723 ms) : 0, 96723
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1099681
Total [baseline] (8.775 s) : 0, 8774554
Agent [candidate] (1.093 s) : 0, 1092736
Total [candidate] (8.816 s) : 0, 8815931
section iast
Agent [baseline] (1.239 s) : 0, 1238575
Total [baseline] (9.417 s) : 0, 9417263
Agent [candidate] (1.233 s) : 0, 1232797
Total [candidate] (9.348 s) : 0, 9347886
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (661.884 ms) : 0, 661884
BytebuddyAgent [candidate] (657.362 ms) : 0, 657362
GlobalTracer [baseline] (286.714 ms) : 0, 286714
GlobalTracer [candidate] (284.967 ms) : 0, 284967
AppSec [baseline] (33.14 ms) : 0, 33140
AppSec [candidate] (32.819 ms) : 0, 32819
Debugger [baseline] (67.467 ms) : 0, 67467
Debugger [candidate] (67.302 ms) : 0, 67302
Remote Config [baseline] (621.248 µs) : 0, 621
Remote Config [candidate] (655.297 µs) : 0, 655
Telemetry [baseline] (8.905 ms) : 0, 8905
Telemetry [candidate] (9.018 ms) : 0, 9018
Flare Poller [baseline] (3.794 ms) : 0, 3794
Flare Poller [candidate] (3.796 ms) : 0, 3796
section iast
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (800.652 ms) : 0, 800652
BytebuddyAgent [candidate] (797.956 ms) : 0, 797956
GlobalTracer [baseline] (260.313 ms) : 0, 260313
GlobalTracer [candidate] (258.426 ms) : 0, 258426
AppSec [baseline] (33.889 ms) : 0, 33889
AppSec [candidate] (33.714 ms) : 0, 33714
Debugger [baseline] (66.629 ms) : 0, 66629
Debugger [candidate] (66.05 ms) : 0, 66050
Remote Config [baseline] (609.104 µs) : 0, 609
Remote Config [candidate] (575.279 µs) : 0, 575
Telemetry [baseline] (8.693 ms) : 0, 8693
Telemetry [candidate] (8.578 ms) : 0, 8578
Flare Poller [baseline] (3.664 ms) : 0, 3664
Flare Poller [candidate] (3.63 ms) : 0, 3630
IAST [baseline] (27.352 ms) : 0, 27352
IAST [candidate] (27.236 ms) : 0, 27236
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (17.146 ms) : 16973, 17319
. : milestone, 17146,
appsec (18.281 ms) : 18096, 18466
. : milestone, 18281,
code_origins (17.877 ms) : 17698, 18056
. : milestone, 17877,
iast (17.629 ms) : 17454, 17804
. : milestone, 17629,
profiling (18.673 ms) : 18486, 18860
. : milestone, 18673,
tracing (17.417 ms) : 17243, 17591
. : milestone, 17417,
section candidate
no_agent (18.925 ms) : 18732, 19118
. : milestone, 18925,
appsec (18.501 ms) : 18314, 18689
. : milestone, 18501,
code_origins (17.827 ms) : 17650, 18003
. : milestone, 17827,
iast (17.472 ms) : 17294, 17649
. : milestone, 17472,
profiling (18.73 ms) : 18542, 18917
. : milestone, 18730,
tracing (17.847 ms) : 17670, 18023
. : milestone, 17847,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.178 ms) : 1166, 1190
. : milestone, 1178,
iast (3.224 ms) : 3180, 3268
. : milestone, 3224,
iast_FULL (5.915 ms) : 5855, 5975
. : milestone, 5915,
iast_GLOBAL (3.545 ms) : 3489, 3600
. : milestone, 3545,
profiling (2.086 ms) : 2067, 2105
. : milestone, 2086,
tracing (1.806 ms) : 1792, 1820
. : milestone, 1806,
section candidate
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.246 ms) : 3206, 3286
. : milestone, 3246,
iast_FULL (5.684 ms) : 5627, 5742
. : milestone, 5684,
iast_GLOBAL (3.573 ms) : 3521, 3626
. : milestone, 3573,
profiling (2.074 ms) : 2056, 2092
. : milestone, 2074,
tracing (1.766 ms) : 1752, 1780
. : milestone, 1766,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (15.693 s) : 15693000, 15693000
. : milestone, 15693000,
appsec (14.642 s) : 14642000, 14642000
. : milestone, 14642000,
iast (18.111 s) : 18111000, 18111000
. : milestone, 18111000,
iast_GLOBAL (18.197 s) : 18197000, 18197000
. : milestone, 18197000,
profiling (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
tracing (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
section candidate
no_agent (15.481 s) : 15481000, 15481000
. : milestone, 15481000,
appsec (14.75 s) : 14750000, 14750000
. : milestone, 14750000,
iast (18.375 s) : 18375000, 18375000
. : milestone, 18375000,
iast_GLOBAL (17.865 s) : 17865000, 17865000
. : milestone, 17865000,
profiling (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
tracing (14.534 s) : 14534000, 14534000
. : milestone, 14534000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~09f26d2619, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.713 ms) : 3493, 3933
. : milestone, 3713,
iast (2.21 ms) : 2145, 2275
. : milestone, 2210,
iast_GLOBAL (2.261 ms) : 2196, 2327
. : milestone, 2261,
profiling (2.096 ms) : 2042, 2151
. : milestone, 2096,
tracing (2.046 ms) : 1994, 2097
. : milestone, 2046,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.731 ms) : 3510, 3952
. : milestone, 3731,
iast (2.216 ms) : 2151, 2282
. : milestone, 2216,
iast_GLOBAL (2.25 ms) : 2184, 2315
. : milestone, 2250,
profiling (2.089 ms) : 2034, 2143
. : milestone, 2089,
tracing (2.051 ms) : 2000, 2103
. : milestone, 2051,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
6997fe7 to
a5f0d36
Compare
0ef488b to
dde4964
Compare
r1viollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The user might notice more overhead by triggering this, though as this is an explicit setting, we can add a warning in the doc.
What Does This Do
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
Motivation
There are users that want to run profiler without tracer (sic). For those, the wallclock profiling is not possible, ATM. This is fixing that gap.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-13347