-
Notifications
You must be signed in to change notification settings - Fork 323
Remove remaining use of JAVA_X_HOME
#10340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bric3
wants to merge
6
commits into
master
Choose a base branch
from
bdu/remove-remaining-use-of-JAVA_X_HOME
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091225
Total [baseline] (10.704 s) : 0, 10703819
Agent [candidate] (1.086 s) : 0, 1086410
Total [candidate] (10.733 s) : 0, 10732849
section appsec
Agent [baseline] (1.267 s) : 0, 1266822
Total [baseline] (10.95 s) : 0, 10949707
Agent [candidate] (1.268 s) : 0, 1267782
Total [candidate] (10.968 s) : 0, 10968433
section iast
Agent [baseline] (1.222 s) : 0, 1222418
Total [baseline] (11.084 s) : 0, 11083726
Agent [candidate] (1.224 s) : 0, 1223983
Total [candidate] (11.324 s) : 0, 11324026
section profiling
Agent [baseline] (1.205 s) : 0, 1204761
Total [baseline] (10.855 s) : 0, 10855394
Agent [candidate] (1.216 s) : 0, 1215855
Total [candidate] (10.86 s) : 0, 10860083
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (655.169 ms) : 0, 655169
BytebuddyAgent [candidate] (651.598 ms) : 0, 651598
GlobalTracer [baseline] (284.344 ms) : 0, 284344
GlobalTracer [candidate] (283.356 ms) : 0, 283356
AppSec [baseline] (32.984 ms) : 0, 32984
AppSec [candidate] (32.695 ms) : 0, 32695
Debugger [baseline] (68.498 ms) : 0, 68498
Debugger [candidate] (68.549 ms) : 0, 68549
Remote Config [baseline] (642.837 µs) : 0, 643
Remote Config [candidate] (642.407 µs) : 0, 642
Telemetry [baseline] (8.961 ms) : 0, 8961
Telemetry [candidate] (9.068 ms) : 0, 9068
Flare Poller [baseline] (3.744 ms) : 0, 3744
Flare Poller [candidate] (3.833 ms) : 0, 3833
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (690.643 ms) : 0, 690643
BytebuddyAgent [candidate] (691.333 ms) : 0, 691333
GlobalTracer [baseline] (258.898 ms) : 0, 258898
GlobalTracer [candidate] (258.954 ms) : 0, 258954
IAST [baseline] (24.656 ms) : 0, 24656
IAST [candidate] (24.503 ms) : 0, 24503
AppSec [baseline] (173.388 ms) : 0, 173388
AppSec [candidate] (172.325 ms) : 0, 172325
Debugger [baseline] (68.709 ms) : 0, 68709
Debugger [candidate] (69.971 ms) : 0, 69971
Remote Config [baseline] (777.573 µs) : 0, 778
Remote Config [candidate] (774.114 µs) : 0, 774
Telemetry [baseline] (9.448 ms) : 0, 9448
Telemetry [candidate] (9.501 ms) : 0, 9501
Flare Poller [baseline] (3.756 ms) : 0, 3756
Flare Poller [candidate] (3.828 ms) : 0, 3828
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (789.883 ms) : 0, 789883
BytebuddyAgent [candidate] (791.885 ms) : 0, 791885
GlobalTracer [baseline] (256.137 ms) : 0, 256137
GlobalTracer [candidate] (256.316 ms) : 0, 256316
IAST [baseline] (27.048 ms) : 0, 27048
IAST [candidate] (26.777 ms) : 0, 26777
AppSec [baseline] (31.718 ms) : 0, 31718
AppSec [candidate] (35.272 ms) : 0, 35272
Debugger [baseline] (68.448 ms) : 0, 68448
Debugger [candidate] (64.6 ms) : 0, 64600
Remote Config [baseline] (612.258 µs) : 0, 612
Remote Config [candidate] (568.901 µs) : 0, 569
Telemetry [baseline] (8.431 ms) : 0, 8431
Telemetry [candidate] (8.386 ms) : 0, 8386
Flare Poller [baseline] (3.603 ms) : 0, 3603
Flare Poller [candidate] (3.539 ms) : 0, 3539
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (702.108 ms) : 0, 702108
BytebuddyAgent [candidate] (709.001 ms) : 0, 709001
GlobalTracer [baseline] (220.412 ms) : 0, 220412
GlobalTracer [candidate] (223.28 ms) : 0, 223280
AppSec [baseline] (32.234 ms) : 0, 32234
AppSec [candidate] (32.639 ms) : 0, 32639
Debugger [baseline] (68.33 ms) : 0, 68330
Debugger [candidate] (69.097 ms) : 0, 69097
Remote Config [baseline] (663.567 µs) : 0, 664
Remote Config [candidate] (652.78 µs) : 0, 653
Telemetry [baseline] (9.025 ms) : 0, 9025
Telemetry [candidate] (8.951 ms) : 0, 8951
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.731 ms) : 0, 3731
ProfilingAgent [baseline] (97.108 ms) : 0, 97108
ProfilingAgent [candidate] (96.879 ms) : 0, 96879
Profiling [baseline] (97.68 ms) : 0, 97680
Profiling [candidate] (97.451 ms) : 0, 97451
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083211
Total [baseline] (8.722 s) : 0, 8722021
Agent [candidate] (1.09 s) : 0, 1089742
Total [candidate] (8.741 s) : 0, 8740684
section iast
Agent [baseline] (1.233 s) : 0, 1232593
Total [baseline] (9.325 s) : 0, 9324508
Agent [candidate] (1.231 s) : 0, 1230974
Total [candidate] (9.343 s) : 0, 9342652
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (651.073 ms) : 0, 651073
BytebuddyAgent [candidate] (655.669 ms) : 0, 655669
GlobalTracer [baseline] (282.512 ms) : 0, 282512
GlobalTracer [candidate] (283.122 ms) : 0, 283122
AppSec [baseline] (32.65 ms) : 0, 32650
AppSec [candidate] (32.792 ms) : 0, 32792
Debugger [baseline] (66.984 ms) : 0, 66984
Debugger [candidate] (67.784 ms) : 0, 67784
Remote Config [baseline] (649.325 µs) : 0, 649
Remote Config [candidate] (628.585 µs) : 0, 629
Telemetry [baseline] (8.939 ms) : 0, 8939
Telemetry [candidate] (9.012 ms) : 0, 9012
Flare Poller [baseline] (3.735 ms) : 0, 3735
Flare Poller [candidate] (3.861 ms) : 0, 3861
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (797.654 ms) : 0, 797654
BytebuddyAgent [candidate] (796.846 ms) : 0, 796846
GlobalTracer [baseline] (258.024 ms) : 0, 258024
GlobalTracer [candidate] (257.423 ms) : 0, 257423
IAST [baseline] (27.214 ms) : 0, 27214
IAST [candidate] (27.27 ms) : 0, 27270
AppSec [baseline] (32.162 ms) : 0, 32162
AppSec [candidate] (33.017 ms) : 0, 33017
Debugger [baseline] (67.961 ms) : 0, 67961
Debugger [candidate] (67.051 ms) : 0, 67051
Remote Config [baseline] (602.579 µs) : 0, 603
Remote Config [candidate] (622.28 µs) : 0, 622
Telemetry [baseline] (8.511 ms) : 0, 8511
Telemetry [candidate] (8.462 ms) : 0, 8462
Flare Poller [baseline] (3.594 ms) : 0, 3594
Flare Poller [candidate] (3.539 ms) : 0, 3539
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.352 ms) : 3306, 3398
. : milestone, 3352,
iast_FULL (5.674 ms) : 5617, 5731
. : milestone, 5674,
iast_GLOBAL (3.701 ms) : 3646, 3755
. : milestone, 3701,
profiling (2.047 ms) : 2029, 2065
. : milestone, 2047,
tracing (1.755 ms) : 1741, 1769
. : milestone, 1755,
section candidate
no_agent (1.193 ms) : 1181, 1205
. : milestone, 1193,
iast (3.195 ms) : 3158, 3232
. : milestone, 3195,
iast_FULL (5.72 ms) : 5664, 5777
. : milestone, 5720,
iast_GLOBAL (3.616 ms) : 3563, 3669
. : milestone, 3616,
profiling (1.97 ms) : 1953, 1987
. : milestone, 1970,
tracing (1.822 ms) : 1807, 1837
. : milestone, 1822,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (18.884 ms) : 18696, 19072
. : milestone, 18884,
appsec (18.261 ms) : 18072, 18449
. : milestone, 18261,
code_origins (17.976 ms) : 17795, 18157
. : milestone, 17976,
iast (18.806 ms) : 18617, 18996
. : milestone, 18806,
profiling (18.674 ms) : 18487, 18861
. : milestone, 18674,
tracing (17.84 ms) : 17663, 18017
. : milestone, 17840,
section candidate
no_agent (18.165 ms) : 17978, 18353
. : milestone, 18165,
appsec (18.34 ms) : 18159, 18521
. : milestone, 18340,
code_origins (17.675 ms) : 17497, 17852
. : milestone, 17675,
iast (17.548 ms) : 17375, 17721
. : milestone, 17548,
profiling (19.146 ms) : 18952, 19339
. : milestone, 19146,
tracing (17.691 ms) : 17516, 17867
. : milestone, 17691,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.538 ms) : 2482, 2595
. : milestone, 2538,
iast (2.238 ms) : 2172, 2304
. : milestone, 2238,
iast_GLOBAL (2.284 ms) : 2218, 2351
. : milestone, 2284,
profiling (2.105 ms) : 2050, 2161
. : milestone, 2105,
tracing (2.064 ms) : 2011, 2116
. : milestone, 2064,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.62 ms) : 3408, 3833
. : milestone, 3620,
iast (2.239 ms) : 2173, 2305
. : milestone, 2239,
iast_GLOBAL (2.278 ms) : 2211, 2344
. : milestone, 2278,
profiling (2.108 ms) : 2052, 2163
. : milestone, 2108,
tracing (2.053 ms) : 2001, 2105
. : milestone, 2053,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a1e732b606, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
appsec (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
iast (18.249 s) : 18249000, 18249000
. : milestone, 18249000,
iast_GLOBAL (17.814 s) : 17814000, 17814000
. : milestone, 17814000,
profiling (14.837 s) : 14837000, 14837000
. : milestone, 14837000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
section candidate
no_agent (15.296 s) : 15296000, 15296000
. : milestone, 15296000,
appsec (14.586 s) : 14586000, 14586000
. : milestone, 14586000,
iast (17.782 s) : 17782000, 17782000
. : milestone, 17782000,
iast_GLOBAL (17.707 s) : 17707000, 17707000
. : milestone, 17707000,
profiling (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
tracing (14.668 s) : 14668000, 14668000
. : milestone, 14668000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR allows to completely get rid of setting up JAVA_X_HOME on local dev environment.
The
stablespecial word has special handling though, that is using Gradle internal toolchain registry, and fallback to env vars. However, this mainly affect CI.Motivation
Easier project setup
Additional Notes
After this PR, setting up JAVA_X_HOME won't be needed anymore. One can use
-PtestJvm=..., e.g.-PtestJvm=11,-PtestJvm=graalvm17, ...