refactor(jetsocat): implement better coloring control for logging#1535
refactor(jetsocat): implement better coloring control for logging#1535RRRadicalEdward wants to merge 2 commits intomasterfrom
Conversation
Let maintainers know that an action is required on their side
|
|
|
||
| #[rstest] | ||
| #[case::default(&[], &[], true)] | ||
| #[case::default(&[], &[], false)] // is_terminal = false |
There was a problem hiding this comment.
In tests, assert_cmd is used to run jetsocat in a child process, where stderr is piped. This means that we always have is_terminal = false. That's why, for example, log_term_coloring with the default case will return false.
There was a problem hiding this comment.
I’ll investigate if we can still check the TTY case properly.
This PR improves coloring control as requested in https://github.com/Devolutions/IronVNC/pull/988#pullrequestreview-3303353388.