-
Notifications
You must be signed in to change notification settings - Fork 16
use Rust 1.91.1 instead of 1.88.0 for maturin 1.9.1 in 2025b toolchain #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
eb_hooks.py
Outdated
|
|
||
| def parse_hook_rust_2025b(ec, eprefix): | ||
| """ | ||
| Replace build dependency on Rust 1.88.0 (used by the 2025b toolchain) by 1.91.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like being consistent, but this does mean we got in uncharted territory compared to EasyBuild...
Maybe we should only do this where we've seen it matter, i.e. for maturin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't really like that it would then basically mix different Rust versions for e.g. Python-bundle-PyPI (which has a build dependency on Rust itself, but also on maturin). But I can give that a try and see if that works. There are not that many easyconfigs that depend on Rust, so we can easily extend that list later on.
|
bot:cancel jobid:943958 |
|
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
|
Testing it locally with EESSI-extend shows that it still works fine after adding the (small) additional changes. |
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
|
New job on instance
|
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.