fix(@effect/vitest): fix compatibility with Vitest 4.0 (#5976)#5980
Open
bxff wants to merge 2 commits intoEffect-TS:mainfrom
Open
fix(@effect/vitest): fix compatibility with Vitest 4.0 (#5976)#5980bxff wants to merge 2 commits intoEffect-TS:mainfrom
bxff wants to merge 2 commits intoEffect-TS:mainfrom
Conversation
🦋 Changeset detectedLatest commit: ecafb0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@mikearnaldi friendly bump |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
This PR fixes an incompatibility with Vitest 4.0 in
@effect/vitest.Vitest 4.0 has removed (or changed) the
onTestFinishedmethod on the test context object, causing aTypeError: ctx?.onTestFinished is not a function.The fix switches to using the top-level
onTestFinishedhook imported directly fromvitest. This is the recommended approach in modern Vitest versions and is fully backward compatible with the current peer dependency (vitest: ^3.2.0), as this export has been available since Vitest 0.34.0.Additionally,
@effect/vitest'speerDependencieshave been updated to explicitly support Vitest 4.x.Related