Peer storage enhancements #8422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
fixes #8382 |
Collaborator
|
@adi2011 can you rebase to prepare this for 25.12 please? |
Collaborator
Author
|
Hi @madelinevibes, sorry for the delay, I was AFK. I’ll try to complete this PR by the end of the week. |
adi2011
force-pushed
the
peer-storage-enhancement
branch
5 times, most recently
from
3cdca8a to
32d4ada
Compare
adi2011
force-pushed
the
peer-storage-enhancement
branch
2 times, most recently
from
da93170 to
ad9078e
Compare
Contributor
|
Because this needs review and it's been delayed, I'm going to move this back to the next milestone. Once rc1 is out I will try to find time for a thorough review! |
madelinevibes
added
the
Status::Ready for Review
adi2011
force-pushed
the
peer-storage-enhancement
branch
2 times, most recently
from
f5aace0 to
7c15c58
Compare
Node should not store SCB that is older than what we already have.
Key Changes:
- store_latest_scb:
Compares the data between the stored scb and latest recvd scb. Compares the data between the stored SCB and the latest received SCB. Since we only need the timestamps, there is no need to deserialize the entire blob.
Adding more information to geremergencyrecoverdata, to let users know if they are using legacy file format and the list of all the backed up channel ids. Key Changes: - Added: 1. can_create_penalty: To let user know if they need to update the file. 2. backed_up_channel_ids: List of all the backed up channels Changelog-Changed: Made getemergencyrecoverdata more verbose.
adi2011
force-pushed
the
peer-storage-enhancement
branch
from
7c15c58 to
8d8ab1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX improvements and some other changes to make peer storage more efficient.
Addresses: #8382