askrene: fixed a timeout corner case #8866
Draft
+147
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've introduced a time out protection in #8636 to avoid hitting infinite loops
in askrene.
I've found a test case that hits the time out, which we don't usually want. We should be smart
enough to detect deadlocks and give up with something like "Payment is unfeasible".
To reproduce the condition we need two channels the first with an HTLC max = x
and the second with a base fee = x. So that any amount f to forward to the 3rd
node requires at least x+f to pass through the first channel, which is not
possible due to the HTLC max limit.
Refine removes all sats from the route and linear routes' while loop continues
coming back to the exact same situation at each iteration. We only end this
timing out.
We fix the infinite loop by deciding (under some arbitrary condition)
when a path has a bottleneck and then disabling one channel in that path that causes the bottleneck.
Important
26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.
RC1 is scheduled on March 23rd
The final release is scheduled for April 15th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade