⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Lagrang3
Copy link
Collaborator

We've introduced a time out protection in #8636 to avoid hitting infinite loops
in askrene.

I've found a test case that hits the time out, which we don't usually want. We should be smart
enough to detect deadlocks and give up with something like "Payment is unfeasible".

To reproduce the condition we need two channels the first with an HTLC max = x
and the second with a base fee = x. So that any amount f to forward to the 3rd
node requires at least x+f to pass through the first channel, which is not
possible due to the HTLC max limit.
Refine removes all sats from the route and linear routes' while loop continues
coming back to the exact same situation at each iteration. We only end this
timing out.

We fix the infinite loop by deciding (under some arbitrary condition)
when a path has a bottleneck and then disabling one channel in that path that causes the bottleneck.

Important

26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.

RC1 is scheduled on March 23rd

The final release is scheduled for April 15th.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

Changelog-Fixed: askrene: fixed a class of corner cases that cause askrene main loop to timeout instead of quickly failing, thus wasting runtime.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant