Do not reveal the side panel if user is scrolling vertically#199
Open
thomasdao wants to merge 2 commits intoFriend-LGA:masterfrom
Open
Do not reveal the side panel if user is scrolling vertically#199thomasdao wants to merge 2 commits intoFriend-LGA:masterfrom
thomasdao wants to merge 2 commits intoFriend-LGA:masterfrom
Conversation
User is usually swipe left or right to reveal the panel and swipe vertically to scroll the content view in the app. It would be more friendly if the side panel is not revealed when user is scrolling vertically.
sewerynek1
reviewed
Oct 19, 2025
| if abs(velocity.y) > abs(velocity.x) { return } | ||
|
|
||
| if self.isRightViewVisibilityStable, | ||
| gesture.state == .began || gesture.state == .changed { |
arc675
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great library!
In my app, I find that sometime scrolling the content on the right edge might accidentally reveal the right side panel. I believe the side panel is usually revealed by swiping left or right and hence it should not be shown when user is scrolling vertically.