⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

[easy] Choose an unused port when logging in.#353

Open
DailyDreaming wants to merge 3 commits intomasterfrom
lon-get-unused-port
Open

[easy] Choose an unused port when logging in.#353
DailyDreaming wants to merge 3 commits intomasterfrom
lon-get-unused-port

Conversation

@DailyDreaming
Copy link
Contributor

@DailyDreaming DailyDreaming commented Jun 3, 2019

Should fix #352.

Using this blocks you as the port 8080 is hard-coded into the whitelist of accepted callback_urls. A suggested work-around (with credit to @Bento007 ): https://community.auth0.com/t/allowed-callback-urls-ending-with-a-wildcard/7626/2

Currently could include changing state in the query_params to include a redirect to a whitelisted uri.

@DailyDreaming DailyDreaming changed the title Choose an unused port when logging in. [easy] Choose an unused port when logging in. Jun 3, 2019
@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #353 into master will decrease coverage by 0.11%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   84.73%   84.61%   -0.12%     
==========================================
  Files          37       37              
  Lines        1756     1762       +6     
==========================================
+ Hits         1488     1491       +3     
- Misses        268      271       +3
Impacted Files Coverage Δ
hca/util/__init__.py 85.13% <42.85%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6200a98...7905beb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure port is open when using hca dss login.

4 participants