[easy] Choose an unused port when logging in.#353
Open
DailyDreaming wants to merge 3 commits intomasterfrom
Open
[easy] Choose an unused port when logging in.#353DailyDreaming wants to merge 3 commits intomasterfrom
DailyDreaming wants to merge 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 84.73% 84.61% -0.12%
==========================================
Files 37 37
Lines 1756 1762 +6
==========================================
+ Hits 1488 1491 +3
- Misses 268 271 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #352.
Using this blocks you as the port 8080 is hard-coded into the whitelist of accepted
callback_urls. A suggested work-around (with credit to @Bento007 ): https://community.auth0.com/t/allowed-callback-urls-ending-with-a-wildcard/7626/2Currently could include changing
statein thequery_paramsto include a redirect to a whitelisted uri.