Open
Conversation
Collaborator
|
@yuzawa-san would you mind giving this a review. We'll include it in Monday's release. |
yuzawa-san
suggested changes
Feb 2, 2026
Contributor
yuzawa-san
left a comment
yuzawa-san
left a comment
There was a problem hiding this comment.
seems like delaware is leaking in
iabgpp-encoder/src/main/java/com/iab/gpp/encoder/section/UsMn.java
Outdated
Show resolved
Hide resolved
iabgpp-encoder/src/main/java/com/iab/gpp/encoder/section/UsMn.java
Outdated
Show resolved
Hide resolved
yuzawa-san
suggested changes
Feb 2, 2026
Contributor
yuzawa-san
left a comment
yuzawa-san
left a comment
There was a problem hiding this comment.
some types appear to be inconsistent with https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/main/Sections/US-States/MN/Minnesota%20Privacy%20Technical%20Specification.md
| fields.put(UsMnField.TARGETED_ADVERTISING_OPT_OUT, | ||
| new EncodableFixedInteger(2, 0).withValidator(nullableBooleanAsTwoBitIntegerValidator)); | ||
| fields.put(UsMnField.SENSITIVE_DATA_PROCESSING, | ||
| new EncodableFixedIntegerList(2, Arrays.asList(0, 0, 0, 0, 0, 0, 0, 0, 0)) |
Contributor
There was a problem hiding this comment.
this is N-Bitfield(2,8) so one of these 0's needs to be removed
| new EncodableFixedIntegerList(2, Arrays.asList(0, 0, 0, 0, 0, 0, 0, 0, 0)) | ||
| .withValidator(nullableBooleanAsTwoBitIntegerListValidator)); | ||
| fields.put(UsMnField.KNOWN_CHILD_SENSITIVE_DATA_CONSENTS, | ||
| new EncodableFixedIntegerList(2, Arrays.asList(0, 0, 0, 0, 0)) |
Contributor
There was a problem hiding this comment.
this is Int(2) so i think it needs to be new EncodableFixedInteger(2, 0).withValidator(nullableBooleanAsTwoBitIntegerValidator)
yuzawa-san
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.