Standardize Settings parameter position #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aram356
requested changes
Jan 26, 2026
Standardize Settings as first parameter across creative module functions for consistency with Rust conventions and improved code discoverability. Resolves: #188
Removes the unused `settings` parameter from `serve_static_with_etag` and `handle_tsjs_dynamic` to clean up the API. Also updates `crates/common/README.md` to match the correct argument order for rewrite helpers. Resolves: #188
prk-Jr
force-pushed
the
188-standardize-settings-parameter-position-always-pass-as-first-argument
branch
from
5d69fd3 to
e36bdd4
Compare
aram356
approved these changes
Jan 28, 2026
ChristianPavilonis
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize Settings as first parameter across creative module functions for consistency with Rust conventions and improved code discoverability.
Resolves: #188