Configure clippy lints #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup workspace lints to enforce coding standards and catch issues during development. 303 tests pass. Resolves: #189
Comprehensive documentation of error and panic conditions improves API clarity and enables gradual enforcement of missing_errors_doc and missing_panics_doc lints. This establishes a foundation for better error handling practices across the codebase. Resolves: #189
The default lint configuration was permissive, allowing unwrap() and panic() in production code. This change enforces stricter error handling by denying these patterns and requiring explicit expect() messages. IntegrationRegistry::new() previously panicked on configuration errors, making startup failures hard to diagnose. Returning Result allows the caller to log meaningful context before returning an error response. Additional pedantic lints (needless_pass_by_value, redundant_closure) help catch common inefficiencies during development.
prk-Jr
force-pushed
the
189-add-clippy-lints-configuration-to-enforce-codebase-consistency
branch
from
8fe64ef to
3bc62da
Compare
Add needless_pass_by_value and redundant_closure_for_method_calls to the list of lints to consider enabling as the codebase matures.
…configuration-to-enforce-codebase-consistency
Fixes clippy::doc_markdown by wrapping the example URL in the origin_override field documentation with angle brackets.
ChristianPavilonis
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup workspace lints to enforce coding standards
and catch issues during development.
Resolves: #189