Fix invalid parsing of the bool arguments#280
Open
mic4ael wants to merge 1 commit intoIdentityPython:masterfrom
Open
Fix invalid parsing of the bool arguments#280mic4ael wants to merge 1 commit intoIdentityPython:masterfrom
mic4ael wants to merge 1 commit intoIdentityPython:masterfrom
Conversation
Author
|
I would be really happy if you could apply the |
Contributor
|
This crashes in production because of memory issues. Will try to reproduce. |
Author
Interesting.. These changes lead to memory issues? |
Contributor
|
no, sorry, I spoke to Hanna and this was sort of a mental note to me that they(/you) have issued with daemon mode and leaking memory. |
Author
|
Ah, ok. That is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR aims to fix the a couple of issues in the argument parsing:
InvertedSettingincorrectly defines its own__get__and__set__dunder methods.daemonizeis missingtypeconvsetting.I have found all these issues (and a few more) while trying to deploy
pyffon our infra at CERN.All Submissions: