Add new GetScope() overload
#85
Merged
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an overload to Owned<T>.GetScope() that exposes the resolved scoped service via an out parameter, and updates the cache runner to use that overload while keeping scope lifetime management unchanged.
Changes:
- Added
GetScope(out T service)overload inOwned<T>and refactored existingGetScope()to delegate to it. - Updated
ApplicationCacheBaseto use the new overload and call the handler via the extractedservicevariable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Immediate.Cache.Shared/Owned.cs | Adds GetScope(out T service) and refactors GetScope() to call it. |
| src/Immediate.Cache.Shared/ApplicationCacheBase.cs | Uses the new GetScope(out ...) overload inside the handler execution path. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.