⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@goatrocks
Copy link
Contributor

@goatrocks goatrocks commented Feb 11, 2026

Note

Medium Risk
Build and toolchain upgrades (Gradle 8/Kotlin 2/Java 21 toolchains) can introduce breaking changes in compilation, publishing, and plugin behavior, plus the regenerated GraphQL schema may affect generated client code.

Overview
Modernizes the build by upgrading Gradle (wrapper to 8.10.2) and multiple plugins/dependencies (notably Kotlin 2.1.10, Shadow 8.1.1, GraphQL plugin 7.0.0, Dokka 2.0.0, Nexus publish 2.0.0, plus JUnit/Ktor/OkHttp/Log4j/annotations bumps).

Updates Gradle configuration to newer APIs (base.archivesName, archiveClassifier.set, allSource, tasks.withType(KotlinCompile)), introduces Java/Kotlin toolchains targeting Java 21 while keeping sourceCompatibility/targetCompatibility at 1.8, and fixes docker-compose.yml to use the services: root.

Adds a newly introspected src/main/graphql/schema.graphql (large schema snapshot) for client generation.

Written by Cursor Bugbot for commit 288b1e7. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

id 'com.expediagroup.graphql' version '5.2.0'
id "org.jetbrains.dokka" version "1.9.0"
id "io.github.gradle-nexus.publish-plugin" version "2.0.0"
id 'com.expediagroup.graphql' version '7.0.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphQL plugin and runtime dependency version mismatch

High Severity

The com.expediagroup.graphql Gradle plugin was upgraded from 5.2.0 to 7.0.0, but the runtime dependencies graphql-kotlin-ktor-client and graphql-kotlin-client-jackson remain at 6.5.3. The GraphQL Kotlin project releases plugin and runtime libraries in lockstep — the plugin at 7.0.0 generates client code expecting 7.x APIs. This mismatch will likely cause compilation or runtime failures when the generated code references classes or methods that don't exist in the 6.5.3 runtime.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant