⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Brano5
Copy link
Collaborator

@Brano5 Brano5 commented Jan 9, 2026

This pull request simplifies how client information is handled during login and logout events in the identity endpoints. Instead of passing a complex ClientIdentification object, only the client's IP address is now passed to the handler delegates. The related code for collecting additional client details has been removed, streamlining the logic.

Delegate and handler signature changes:

  • Changed the LoginHandler and LogoutHandler delegate signatures to accept only the ipAddress string instead of a ClientIdentification object. (IdentityComponentsEndpointRouteBuilderExtensions.cs)

Simplification of client info usage:

  • Updated all usages of loginHandler and logoutHandler within MapAdditionalIdentityEndpoints to pass only the IP address, removing the creation and use of the ClientIdentification object. (IdentityComponentsEndpointRouteBuilderExtensions.cs) [1] [2] [3] [4] [5]

Code cleanup:

  • Removed the ClientIdentification class and the GetClientIdentification method, as they are no longer needed. (IdentityComponentsEndpointRouteBuilderExtensions.cs) [1] [2]

@Brano5 Brano5 self-assigned this Jan 9, 2026
@PTKu PTKu merged commit b45472a into dev Jan 20, 2026
1 check passed
@PTKu PTKu deleted the logout-helper-improvements-identity-endpoints branch January 20, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants