Conversation
|
I like that solution better than having the dynamic linkage pod installed. Can confirm it works for our setup |
@dazlious -- you would still need dynamic linkage. This is for header resolution. |
ios/RNIterableAPI/RNIterableAPI.mm
Outdated
| }; | ||
|
|
||
| #import "Iterable_React_Native_SDK-Swift.h" | ||
| #import <Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h> |
There was a problem hiding this comment.
Hi @alexstaravoitau. This could potentially break things depending on a users podfile setup. It would be safer for this to be conditional to account for that.
Untested pseudocode example:
#if __has_include(<Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h>)
#import <Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h>
#else
#import "Iterable_React_Native_SDK-Swift.h"
#endifThere was a problem hiding this comment.
Makes sense, updated. 👌
Indeed, but I would not need the dynamic cocoapod plugin |
…eact-native-sdk into fix-xcode-build-issues
🔹 JIRA Ticket(s) if any
✏️ Description
Fixes Xcode build issues by switching to angled header import in
RNIterableAPI.mm.