Draft: Fyne store type UI by spbsoluble · Pull Request #303 · Keyfactor/kfutil

spbsoluble · 2026-01-20T17:15:54Z

No description provided.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…ntegration-manifest.json feat(cli/pam): Add support for get and delete pam types. fix(cli/pam): Remove check for bug ab#63171 Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…ile for PAM types. refactor(cli/pam): Split PAM code into 2 files one for PAM Types and the other for PAM providers. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…avoid storing creds on disk and in env vars. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

… passed Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

BREAKING CHANGE: All `pam types-*` are now `pam-types <action>` Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…e changes for a profile. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…some of the definition issues. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 131 out of 135 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 131 out of 135 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 133 out of 137 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 134 out of 138 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-20T22:51:39Z

store_types.json

        "Description": "Login password for the F5 Big IQ device."
      }
    ],
-    "EntryParameters": [
-      {
-        "Name": "Alias",
-        "DisplayName": "Alias (Reenrollment only)",
-        "Type": "String",
-        "RequiredWhen": {
-          "HasPrivateKey": false,
-          "OnAdd": false,
-          "OnRemove": false,
-          "OnReenrollment": true
-        },
-        "DependsOn": "",
-        "DefaultValue": "",
-        "Options": "",
-        "Description": "The name F5 Big IQ uses to identify the certificate"
-      },
-      {
-        "Name": "Overwrite",
-        "DisplayName": "Overwrite (Reenrollment only)",
-        "Type": "Bool",
-        "RequiredWhen": {
-          "HasPrivateKey": false,
-          "OnAdd": false,
-          "OnRemove": false,
-          "OnReenrollment": true
-        },
-        "DependsOn": "",
-        "DefaultValue": "False",
-        "Options": "",
-        "Description": "Allow overwriting an existing certificate when reenrolling?"
-      },
-      {
-        "Name": "SANs",
-        "DisplayName": "SANs (Reenrollment only)",
-        "Type": "String",
-        "RequiredWhen": {
-          "HasPrivateKey": false,
-          "OnAdd": false,
-          "OnRemove": false,
-          "OnReenrollment": false
-        },
-        "DependsOn": "",
-        "DefaultValue": "",
-        "Options": "",
-        "Description": "External SANs for the requested certificate. Each SAN must be prefixed with the type (DNS: or IP:) and multiple SANs must be delimitted by an ampersand (&). Example: DNS:server.domain.com&IP:127.0.0.1&DNS:server2.domain.com.  This is an optional field."
-      }
-    ]
+    "EntryParameters": []


Typo in the word "delimitted" should be "delimited".

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Copilot reviewed 134 out of 138 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 134 out of 139 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

spbsoluble added 30 commits December 4, 2025 10:03

chore(deps): Update dependencies to latest versions

168bfd4

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam): Add support for creating a pam provider type from an i…

2be1684

…ntegration-manifest.json feat(cli/pam): Add support for get and delete pam types. fix(cli/pam): Remove check for bug ab#63171 Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(store-types): Update internal store-type definitions to latest

b6066f1

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam-types): Embed existing PAM types

1be6293

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam): Add support for parsing an integration-manifest.json f…

a943161

…ile for PAM types. refactor(cli/pam): Split PAM code into 2 files one for PAM Types and the other for PAM providers. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/auth): Allow for interactive auth on a per command basis to …

f258ec1

…avoid storing creds on disk and in env vars. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(docs): Update auth_providers.md with oauth example.

865ddbd

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Bump keyfactor-go-client

8167ee4

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Update all deps to latest

58eaa8e

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

fix(cli/auth): Don't prompt on known values when incomplete config is…

116f85c

… passed Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam): Delete by name supported.

8a1a11b

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam-types)!: Rescope pam types CLI actions to pam-types

daee467

BREAKING CHANGE: All `pam types-*` are now `pam-types <action>` Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(docs): Regenerate auto docs.

2c81741

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Bump keyfactor-go-client

174a3b9

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/pam-types): Add mock tests for pam-types sub CLI

9a7c20e

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(lint): Fix go vet issues.

ecd9076

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

fix(cli/login): login will clear out basic/oauth params if auth typ…

d23514e

…e changes for a profile. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

fix(cli/store-types): Sort store-types list case-insensitively

38ecb29

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/store-types): Convert store-types tests to mocks and fix …

e4adc2b

…some of the definition issues. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/store-types): Add mock server to store-types tests.

3b8e753

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/pam-types): Add mock server to pam-types tests.

19ad7c5

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore: Update license headers on files.

be62176

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Add workflow to run mock tests.

79f1bd1

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Remove "old" tests workflow

5671c97

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci/mock_tests): Dynamic summary for mock tests

880d422

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci/mock_tests): Always run mocks

dba0898

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci/mock_tests): Always run all store-type mocks

98169ab

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Update workflow ref versions to latest

c3ca543

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Bump golang version to v1.25

d6f23fb

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Fix container digest uploads.

4d82a32

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI reviewed Jan 20, 2026

View reviewed changes

spbsoluble added 2 commits January 20, 2026 13:01

chore(ci): Comment out freebsd build

ab40b35

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Comment out freebsd build

ed6eaee

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 20, 2026 21:30

Copilot started reviewing on behalf of spbsoluble January 20, 2026 21:30 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

spbsoluble added 2 commits January 20, 2026 13:40

chore(ci): Split build to allow for CLI only build

88bf677

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Comment out GUI build for now.

e9fd36c

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 20, 2026 22:07

Copilot started reviewing on behalf of spbsoluble January 20, 2026 22:07 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

spbsoluble added 2 commits January 20, 2026 14:45

chore(ci): Bump build workflow version

789a9b7

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Only try and build linux GUIs

30ab47e

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 20, 2026 22:49

Copilot started reviewing on behalf of spbsoluble January 20, 2026 22:49 View session

chore(ci): Only try and build linux GUIs

f2d04a9

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI reviewed Jan 20, 2026

View reviewed changes

spbsoluble added 2 commits January 20, 2026 14:52

chore(ci): Only try and build linux GUIs

c1c7c5d

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Only try and build linux GUIs

67ad51b

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 20, 2026 22:53

Copilot started reviewing on behalf of spbsoluble January 20, 2026 22:53 View session

chore(ci): Only try and build linux GUIs

4c2b9ca

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI reviewed Jan 20, 2026

View reviewed changes

spbsoluble added 2 commits January 20, 2026 14:59

chore(ci): Only try and build linux GUIs

93219a9

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Only try and build linux GUIs

208e888

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 20, 2026 23:12

Copilot started reviewing on behalf of spbsoluble January 20, 2026 23:13 View session

chore(ci): Only try and build linux GUIs

08a140e

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI reviewed Jan 20, 2026

View reviewed changes

chore(ci): Add fyne app metadata

f8e0fc4

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draft: Fyne store type UI#303

Draft: Fyne store type UI#303
spbsoluble wants to merge 64 commits intorelease-1.9from
fyne_store-type_ui

spbsoluble commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

spbsoluble commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant