⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Add shap to ML training/testing libraries#161

Merged
tvami merged 1 commit intomainfrom
iss160-add-shap
Feb 5, 2026
Merged

Add shap to ML training/testing libraries#161
tvami merged 1 commit intomainfrom
iss160-add-shap

Conversation

@tvami
Copy link
Member

@tvami tvami commented Feb 4, 2026

I am adding a new package to the container, here are the details.

Resolves #160

What new packages does this PR add to the development image?

  • shap

Check List

  • I successfully built the container using docker
  • I was able to successfully use the new packages.
docker build . -t ldmx/local:temp-tag
docker run -it --rm -v $PWD:$PWD -w $PWD ldmx/local:temp-tag
python3 -c "import shap"
root@1ae77df9afa4:/tmp/dev-build-context# 

So it works

@JYoo001
Copy link

JYoo001 commented Feb 5, 2026

Great, thank you!

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm fine with including this, I do want to point out that the python ecosystem has much better environment handling than building frozen packages into container images.

I would suggest using uproot/awkward instead of PyROOT. The annoyance of switching to a different package will be outweighted by the time saved (uproot/awkward is faster) and the ease of use. Without using PyROOT, you can just

uv init
uv add scikit-hep

and you are good to go with the latest packages which you can mirror across machines by carrying around the uv.lock file that uv creates. https://docs.astral.sh/uv/

@tvami
Copy link
Member Author

tvami commented Feb 5, 2026

Yes it's long overdue to move the UCSB scripts to uproot. But ok for now let's just merge this. Do I need to cut a release for this to work @tomeichlersmith ?

@tvami tvami merged commit 48d0d9a into main Feb 5, 2026
15 checks passed
@tvami tvami deleted the iss160-add-shap branch February 5, 2026 20:14
@tomeichlersmith
Copy link
Member

Now that's its merged, it will be built into ldmx/dev:main. A new release would build a new tag that would update ldmx/dev:latest.

This will not propagate into ldmx/pro until a new release of ldmx-sw is made after its Dockerfile is updated to point to the updated ldmx/dev image.

@tvami
Copy link
Member Author

tvami commented Feb 5, 2026

OK so I'd like it to be in the ldmx/dev:latest, I'll make a release then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shap Package request

3 participants