fix(drawing): correct opacity handling for text and shapes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs were causing opacity to not work: 1. Swapped CA/ca parameters in registerGraphicsStateForOpacity: - CA (uppercase) is for stroking operations (borders) - ca (lowercase) is for non-stroking operations (fills, text) 2. Missing '/' prefix when setting graphics state: - setGraphicsState expects '/GS0' but was receiving 'GS0' Added comprehensive opacity tests for all drawing methods including rectangles, circles, ellipses, lines, text, paths, and images.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks for fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs were causing opacity to not work:
Swapped CA/ca parameters in registerGraphicsStateForOpacity:
Missing '/' prefix when setting graphics state:
Added comprehensive opacity tests for all drawing methods including
rectangles, circles, ellipses, lines, text, paths, and images.
Resolves #4