[FEATURE] Add consumeWhitespaceWithComments and redirect consumeWhitespace (backported)#670
Open
ziegenberg wants to merge 2 commits intoMyIntervals:v8.xfrom
Open
Conversation
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this pull request
Aug 25, 2024
…space (MyIntervals#670) Having comsumeWhitespace also consume comments and returning them was unexpected. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this pull request
Aug 25, 2024
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-comsume-whitespacewithcomment
branch
from
a07190b to
b92f7c3
Compare
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this pull request
Aug 25, 2024
…space (MyIntervals#670) Having comsumeWhitespace also consume comments and returning them was unexpected. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this pull request
Aug 25, 2024
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-comsume-whitespacewithcomment
branch
from
b92f7c3 to
79b271f
Compare
ziegenberg
changed the title
…space (MyIntervals#670) Having comsumeWhitespace also consume comments and returning them was unexpected. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-comsume-whitespacewithcomment
branch
from
79b271f to
d53d9ba
Compare
ziegenberg
changed the title
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
requested changes
Aug 25, 2024
Collaborator
oliverklee
left a comment
oliverklee
left a comment
There was a problem hiding this comment.
Thanks! Could you also add a test for the new method? (Copying and modifying the test for the other method should be fine.)
Contributor
Author
|
Contributor
Author
|
Sorry, clicked the wrong buttons... |
Collaborator
|
This should go into |
Collaborator
|
And (as far as I see) as this isn't necessary for the bugfix (please correct me if I'm wrong) and does not provide any user-/developer facing new feature, I'd prefer this to go into |
oliverklee
modified the milestones:
9.1.0: Add support for PHP 8.5,
9.2.0: New features, bug fixes and deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having
consumeWhitespacealso consumes comments, and returning them was unexpected. This also "deprecates" the consumeWhitespace method and announces a breaking change for 9.0.0.