⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@aidenvaines-cgi
Copy link
Contributor

Description

  • Fixing the make test-* targets to better show where they are not implemented.
make test-ui            
test-ui: Not currently implemented
Create ./scripts/tests/ui.sh to implement this test target
  • Fixing the Terraform targets too to properly work with tfscaffold (still needs the symlinking from internal for local BC dev)
  • Re-run all githooks

Context

Repo template silently fails on missing test scripts and i dug a bit deep into the makefiles

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@aidenvaines-cgi aidenvaines-cgi requested review from a team as code owners February 9, 2026 15:46
@aidenvaines-cgi aidenvaines-cgi requested a review from a team as a code owner February 9, 2026 15:53
sidnhs
sidnhs previously approved these changes Feb 9, 2026
@aidenvaines-cgi aidenvaines-cgi merged commit b512b7b into main Feb 10, 2026
32 checks passed
@cgitim cgitim deleted the CCM-14510_FixTestAndTerraformMakTargets branch February 10, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants