⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@nhsd-david-wass
Copy link
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-david-wass nhsd-david-wass requested review from a team as code owners January 29, 2026 08:51
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12939-Event-Audit-Pipeline branch 21 times, most recently from b52dff8 to 0d248b4 Compare February 4, 2026 11:57
@@ -1,4 +1,4 @@
resource "aws_kinesis_firehose_delivery_stream" "main" {
resource "aws_kinesis_firehose_delivery_stream" "eventsub" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be a little careful about renaming things, since Terraform's default behaviour is to tear down the old resource and create the new one. That could be disruptive now that we have real data going through production. It might be safer to add a moved block tying the old name to the new name, so that Terraform knows to rename rather than destroy and recreate

resources = [
module.eventsub.sns_topic.arn
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about where this change came from - it matches a change on an unmerged branch of mine, but I'm not sure it's needed on this branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may have just been me trying to get things to appear in the correct place.
I'll remove it from here and check everything works

@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12939-Event-Audit-Pipeline branch from 4256d27 to 2f2bc2c Compare February 5, 2026 08:53
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12939-Event-Audit-Pipeline branch from 69659e8 to 40f6ebe Compare February 9, 2026 15:22
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12939-Event-Audit-Pipeline branch from 40f6ebe to 9405515 Compare February 9, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants