Feature/ccm 12950 transform publish updates

[stevebux]

Description

Context

Type of changes

• Refactoring (non-breaking change)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would change existing functionality)
• Bug fix (non-breaking change which fixes an issue)

Checklist

• I am familiar with the contributing guidelines
• I have followed the code style of the project
• I have added tests to cover my changes
• I have updated the documentation accordingly
• This PR is a result of pair or mob programming
• If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

---

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

• I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

[masl2]

Is it also worth renaming the queue and status lambda to adopt the amendment naming?

It would also make it clearer vs the status_update events

[stevebux]

Is it also worth renaming the queue and status lambda to adopt the amendment naming?

It would also make it clearer vs the status_update events

I did look at renaming the queue and lambda, under the previous ticket I think, but got scared of possible merge conflicts. It is probably worth doing though, so I'll bite the bullet and get it done under this ticket.

The base branch was changed.

[aidenvaines-cgi]

Why bother moving, are there targets which can't be re-created?
destroy and rename would be much cleaner.

Why the rename to start with? this SNS topic is the only one in the eventsub module, terraform practice is for singleton resources to be named main

[stevebux]

I wasn't sure of the consequences of doing a destroy and recreate when there is production data moving through the system. If you think it would be it would be just as safe as doing a move (and cleaner) I'm happy to go with that.

This ticket adds a second sns topic to the eventsub module, amendments_topic, which is why I renamed main.

[masl2]

If that is the case - should this topic be create outside the eventsub module?
... now that I've typed that out - that might be sensible