Closed
Conversation
Tomdango
reviewed
Jan 11, 2024
Collaborator
Tomdango
left a comment
Tomdango
left a comment
There was a problem hiding this comment.
Looks super overall - just a couple of comments 👍
…or now, pending chromatic integration.
…t the id and/or name to stop autoID generation.
|
KaiSpencer
changed the title
Collaborator
|
Linking this with #192 (comment) Can we pick this up as part of #216? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storybook has a new test runner built in, that comprises of Jest and Playwright, allowing a variety of testing techniques such as: visual tests, snapshot tests, a11y tests - Docs
This is a proof of concept to see how we could use the built in storybook testing to automatically have snapshot tests without having to define a test case per component. See config in
.storybook/test-runner.tsThis also experiments with the visual image testing, where a similar
screenshotis taken (rendered under the hood with playwright and jest)