Draft
Conversation
merged to bring develop changes into the work-in-progress branch
Collaborator
|
@tmorshed what is the future of this PR? Is it close to completion? Were there some structural issues with it still? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to make a new experiment class
eegnb.experiments.resting_statewhich includes "resting"-type tasks.Progress:
rsexperiments.Issues:
BaseExperimentclass handles theitiandsoabetween stimuli such that an iteration of events is assigned to one block, and does thewin.flip()between trials. This causes the third and later beeps to not come through correctly.Solution: either
iti/soa/block design are infer-able using added higher-level input.aob.pywherein we do not use abinomialdistribution, but rather a repetitive 0,1,0,1 stimulus parameter.rs.RestingStateexperiment overrides theload_stimulus()andpresent_stimulus()classes and even creates a customrun_ts()method to run the experiment. Will be reverted after the new implementation is brought forward.