⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@BIA3IA
Copy link
Contributor

@BIA3IA BIA3IA commented Nov 14, 2025

Closes #13

@BIA3IA BIA3IA marked this pull request as ready for review November 14, 2025 13:08
@BIA3IA BIA3IA marked this pull request as draft November 14, 2025 13:26
@BIA3IA BIA3IA marked this pull request as ready for review November 14, 2025 14:12
@BIA3IA BIA3IA added difficulty: easy Beginner-friendly issue — low complexity priority: high High priority — critical for functionality or release area: frontend Relates to frontend or user interface code labels Nov 18, 2025
Copy link
Contributor

@toto04 toto04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao! Grazie mille per la PR, molto precisa, come previsto ti faccio un po' di nitpicking per fare tutto preciso.

Una cosa che abbiamo notato per quanto riguarda il rounded-buttonM che non funziona in tailwind: avendo il glass già la classe rounded-lg, tailwind-merge non sapeva come unire le cose dato che la nostra è custom, stando alla loro documentazione va estesa la funzione cn in `@/lib/utils.ts/ così:

import { type ClassValue, clsx } from "clsx"
import { extendTailwindMerge } from "tailwind-merge"

const twMerge = extendTailwindMerge({
  extend: {
    theme: {
      radius: ["images", "rectangles", "buttonsM", "buttonsL"], // custom rounded classes from figma
    },
  },
})

export function cn(...inputs: ClassValue[]) {
  return twMerge(clsx(inputs))
}

Prova a modificare la cosa in questo modo e guarda se buttonM funziona come previsto.
Potrebbe essere che sarà necessario in futuro fare cose simili anche per i colori di Figma, ma non ho verificato. Apro io una issue per questa cosa.

@BIA3IA BIA3IA requested a review from toto04 November 20, 2025 08:53
@toto04
Copy link
Contributor

toto04 commented Nov 20, 2025

Nice ottimo lavoro, bravissima LGTM 👍

@toto04 toto04 merged commit b0454c6 into main Nov 20, 2025
1 check passed
@toto04 toto04 deleted the bianca/input branch November 20, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: frontend Relates to frontend or user interface code difficulty: easy Beginner-friendly issue — low complexity priority: high High priority — critical for functionality or release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input

4 participants