-
Notifications
You must be signed in to change notification settings - Fork 1
v1.10.0 #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aristath
wants to merge
379
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22,276
−5,838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test on Playground |
…251031 Add PHPUnit Coverage workflow
Contributor
Composer package changes
|
Contributor
✅ Code Coverage Report
🎉 Great job maintaining/improving code coverage! 📊 File-level Coverage Changes (156 files)🆕 New Files
ℹ️ About this report
|
Fixed 4 test failures identified in GitHub Actions CI: 1. Ajax_Security_AIOSEO_Test::test_uses_base_trait - Changed from getTraitNames() to hasMethod() checks - getTraitNames() only returns direct traits, not nested traits - Now verifies base trait methods are available 2. Ajax_Security_Yoast_Test::test_uses_base_trait - Same fix as AIOSEO test - Checks for verify_nonce_or_fail, verify_capability_or_fail, verify_ajax_security 3. Input_Sanitizer_Test::test_get_sanitized_post_sanitization (special_chars) - Fixed expected value for ampersand test - sanitize_text_field() does not encode ampersands - Changed expectation from 'Test & Value' to 'Test & Value' 4. Input_Sanitizer_Test::test_get_sanitized_get_sanitization (special_chars) - Same fix as above for GET method All tests now properly reflect WordPress function behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The tests were catching WPAjaxDieStopException but wp_send_json_error() actually throws WPAjaxDieContinueException. Fixed in: - test-class-ajax-security-base.php (2 occurrences) - test-class-ajax-security-aioseo.php (1 occurrence) - test-class-ajax-security-yoast.php (1 occurrence) This fixes the 4 test errors: - Ajax_Security_Base_Test::test_verify_nonce_or_fail_invalid - Ajax_Security_Base_Test::test_verify_capability_or_fail_non_admin - Ajax_Security_AIOSEO_Test::test_verify_aioseo_active_or_fail_not_active - Ajax_Security_Yoast_Test::test_verify_yoast_active_or_fail_not_active 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…ion-with-traits Reduce code duplication using traits
…ctive-task-load Dont enqueue assets or add popover if interactive task is not published
…grid-as-dependency Dont enqueue grid script on WP Dashboard page
…omment-workflow Improve version handling in zip file
Add a plugin check action
New user onboarding
New onboarding tweaks
Reverse logic for "Show Onboarding" filter
Delay onboarding init a bit
…e-access-check Exclude direct_file_access check from plugin-check
…itioning Remove custom positioning for "Interactive task" popover
Update for 'Remove custom positioning for "Interactive task" popover'
…gin-update Add null guards to prevent fatal errors during pp-hosts plugin updates
…submission Fix interactive task form resubmission after error and improve task completion check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.