fix: revert np.where to xarray.where when adding vars/ constraints #575
+2
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#555 introduced masking and used
np.whereinstead ofxarray.wheresince is is "38x faster than xarray where".But
xarrayis slower for a reason, since it aligns operands by dimension name, not just position.np.whererequires shapes to match positionally, which is not guaranteed inadd_variablesoradd_constraints. This PR just reverts the changes, we should add tests and release a patch tomorrow.See https://github.com/PyPSA/linopy/pull/555/changes#diff-1a9bf239769f2af33c90e00a21f7f08e2f40d626ce06ee470bb2daa65ac06a04R788-R789