[Pyomo.DoE] Replace computationally expensive test example with Rooney Biegler #3828
+1,405
−576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ample did not solve to the desired point using A-optimality. However, when initialized to small value `1e-5`, it solved to the optimal point.
…scheme, the MM model solved without initialization from outside.
…`doe/tests`` files to reflect the changes.
…n `doe/test_utils.py`
…erstanding in ``doe/test_utils.py``
…and `_Cholesky_option = False`. Add flag for functions are the only used in `trace` calculation.
Replace `model` with `m` in `cholesky_LLinv_imp()` Co-authored-by: Bethany Nicholson <[email protected]>
… and add `doe_example..py` based on the rooney_biegler.py
…gler/doe_example.py`
… change-a-optimality
…olve.py` with rooney_biegler` example
…iment()` function
- Introduced `RooneyBieglerExperimentFlag` to support model completeness flags for error handling in experiments. - Updated test files to utilize `RooneyBieglerExperiment` and `RooneyBieglerExperimentFlag` for better isolation and error testing. - Removed references to `FullReactorExperiment` in favor of the new Rooney-Biegler experiment classes. - Adjusted design ranges and parameters in tests to align with the new experiment structure. - Improved test descriptions and organization for clarity and maintainability.`
smondal13
changed the title
Contributor
Author
|
@blnicho @adowling2 This PR is ready for initial design review. @blnicho, one of the tests is failing. Can you please take a look? Note: This PR depends on #3803 |
…sitivity_formula parameters; update tests accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Most unit tests within
pyomo/contrib/doe/testsutilized thereactor_example.pyexample, which is computationally expensive for the scope of these tests. This resulted in unnecessarily long execution times for the test suite.This PR replaces the
reactor_example.pywith the simplerrooney_biegler_doe_example.pyexample in the tests. This change maintains the validity of the tests while significantly reducing computational overhead.Performance Impact (MacBook with M4 chip):
Before: ~20 seconds
After: ~12 seconds
Improvement: ~40% reduction in test execution time.
Changes proposed in this PR:
reactor_example.pywithrooney_biegler_doe_example.pyin pyomo/contrib/doe/tests.rooney_biegler_doe_example.pymodel structure.Note:
This PR relies on PR #3803
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: