refactor: simplify future usage within the api clients#263
refactor: simplify future usage within the api clients#263allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
|
I am sending this for initial feedback, but i have not tested exhaustively. I'd like to further ensure there is sufficient test coverage for these cases, etc. |
humbertogontijo
left a comment
There was a problem hiding this comment.
Seems like good improvements to me.
Any thoughts @Lash-L ?
Lash-L
left a comment
There was a problem hiding this comment.
I think this looks good to me, i'll want to do further testing before it's fully in HA, but i don't think that needs to hold up the package release
|
Alright. I can merge it once conflicts are solved |
|
I figured out a way to write tests some tests that use a fake MQTT broker, so let me get that working then i'll come back to this and resolve the conflicts and make sure everything passes. |
|
Using this as a quick chat Now that it is in the org- we should all be able to merge in PRs. But it should still be set so that you have to have one review. So whoever makes the PR should wait for one of the other two to approve it before merging. |
89ed5cf
5f17c2b to
89ed5cf
Compare
89ed5cf to
4a572d9
Compare
4a572d9 to
9fe6575
Compare
|
OK, these changes should have improved test coverage now and ready for another look after rebasing/merging. |
Lash-L
left a comment
There was a problem hiding this comment.
This all looks good to me - before we do the next bump in core though i'll want to run the package a good bit any make sure nothing breaks.
For now though, I think we are good to merge this, it probably makes sense for me to just check it after the whole refactoring process is done
Simplify future usage within the api clients by separating how message results and exceptions are passed, using built in exception handling in futures. This raises exceptions instead of returning exceptions. This is a step of simplification on the path to fixing some concurrency issues in the client libraries.
Issue #228