fix: update log message to include existing request id#264
Merged
humbertogontijo merged 2 commits intoPython-roborock:mainfrom Jan 6, 2025
Merged
fix: update log message to include existing request id#264humbertogontijo merged 2 commits intoPython-roborock:mainfrom
humbertogontijo merged 2 commits intoPython-roborock:mainfrom
Conversation
allenporter
changed the title
humbertogontijo
approved these changes
Jan 6, 2025
humbertogontijo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update log message about invalid state to also include existing request id. Some requests are sent with a fixed id so would be good to rule those out.
Updates #228